Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N21-1512 Fix SchoolExternalTool metadata #4580

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

MarvinOehlerkingCap
Copy link
Contributor

@MarvinOehlerkingCap MarvinOehlerkingCap commented Nov 24, 2023

Description

Links to Tickets or other pull requests

https://ticketsystem.dbildungscloud.de/browse/N21-1512
hpi-schul-cloud/nuxt-client#2925

Changes

Datasecurity

Deployment

New Repos, NPM pakages or vendor scripts

Approval for review

  • DEV: If api was changed - generate-client:server was executed in vue frontend and changes were tested and put in a PR with the same branch name.
  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • All points were discussed with the ticket creator, support-team or product owner. The code upholds all quality guidelines from the PR-template.

Notice: Please remove the WIP label if the PR is ready to review, otherwise nobody will review it.

@@ -40,11 +40,11 @@ export class ExternalToolMetadataService {
);
}

const externaltoolMetadata: ExternalToolMetadata = new ExternalToolMetadata({
const externalToolMetadata: ExternalToolMetadata = new ExternalToolMetadata({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@MarvinOehlerkingCap MarvinOehlerkingCap merged commit 537571d into main Nov 27, 2023
46 of 47 checks passed
@MarvinOehlerkingCap MarvinOehlerkingCap deleted the N21-1512-fix-ctl-metadata branch November 27, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants